Attempted to fix #141972 Parameter ABI inconsistency error in Rust for RISC-V #141979

YingkaiLi-VM · 2025-06-03T18:44:31Z

No description provided.

rustbot · 2025-06-03T18:44:35Z

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

workingjubilee · 2025-06-03T18:58:44Z

r? @workingjubilee

sorry for not reviewing your PR yet, @beetrees, but can you check if this would overlap with #139340

beetrees · 2025-06-03T19:15:54Z

This is unrelated: #139340 is about structs with floating point fields passed via the "C" ABI, whereas #141972 is about integers being passed with the "Rust" ABI.

workingjubilee · 2025-06-03T20:18:04Z

@YingkaiLi-VM please rebase on the current master branch

bors · 2025-06-09T06:16:59Z

☔ The latest upstream changes (presumably #142220) made this pull request unmergeable. Please resolve the merge conflicts.

…64 architecture.

YingkaiLi-VM · 2025-06-11T08:20:32Z

@bors @workingjubilee Okay，Merge conflicts resolved. Thanks for your help!

jieyouxu · 2025-06-15T15:43:55Z

@rustbot review

workingjubilee · 2025-06-16T07:23:45Z

tests/ui/abi/debug.rs

@@ -7,6 +7,9 @@
 //@ normalize-stderr: "(valid_range): [1-9]\.\.=(429496729[0-9]|1844674407370955161[0-9])" -> "$1: $$NON_NULL"
 // Some attributes are only computed for release builds:
 //@ compile-flags: -O
+//@ revisions: generic riscv64
+//@ [riscv64] only-riscv64


Can you make this a cross-compiling test?

See this for an example of what that looks like: 6cea550

You will also want to add something like this:

//@ add-core-stubs #![feature(no_core)] #![no_core] extern crate minicore;

If using this approach:

#![feature(no_core)] #![no_core] extern crate minicore;

The code will fail to compile with the error: the trait bound str: Sized is not satisfied.

If using this approach (conditional compilation comments):

//@ revisions: generic riscv64 //@ [riscv64] compile-flags: --target riscv64gc-unknown-linux-gnu //@ [riscv64] needs-llvm-components: riscv

This test will only apply to the target riscv64gc-unknown-linux-gnu.

@workingjubilee I'm not sure if my understanding is correct, but personally, I believe this particular test itself is intended to be a generic test. Thanks.

The test can only be blessed if it is cross-compiled. Changes to the specifics of rustc's internals will make this test fail and then, because we do not run tests on riscv targets, we will not run this revision of this test, and it will fall out of sync.

You need //@ add-core-stubs to make the minicore crate compiled with it.

And "str is not Sized" is already a part of the test output:

rust/tests/ui/abi/debug.riscv64.stderr

Lines 878 to 885 in 3a036a1

error[E0277]: the size for values of type `str` cannot be known at compilation time

--> $DIR/debug.rs:57:46

|

LL | type TestAbiEqNonsense = (fn((str, str)), fn((str, str)));

| ^^^^^^^^^^ doesn't have a size known at compile-time

|

= help: the trait `Sized` is not implemented for `str`

= note: only the last element of a tuple may have a dynamically sized type

That is already an error.

I am happy to accept the PR you are currently offering but I need you to understand that you are signing yourself up for this test instead potentially breaking in a new way every time you update rustc and run the tests on your RV64 host. As opposed to now, where it will just be broken in this same way every time.

Okay, thanks for your help. I'll look into how to fix this

rustbot assigned fee1-dead Jun 3, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2025

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2025

This comment has been minimized.

Sign in to view

rustbot assigned workingjubilee and unassigned fee1-dead Jun 3, 2025

workingjubilee removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2025

This comment has been minimized.

Sign in to view

YingkaiLi-VM force-pushed the master branch from f36cb1f to 2676796 Compare June 5, 2025 15:50

rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2025

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 9, 2025

This comment has been minimized.

Sign in to view

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Jun 11, 2025

YingkaiLi-VM added 3 commits June 11, 2025 14:28

Fixed the ABI parameter inconsistency issue in debug.rs for the riscv…

65e616d

…64 architecture.

Delete tests/ui/abi/debug.stderr

2a01775

Fix conflict in debug.riscv64.stderr file

401997c

YingkaiLi-VM force-pushed the master branch from 50787e1 to 401997c Compare June 11, 2025 06:32

rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2025

Fix conflict in debug.generic.stderr file

3a036a1

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2025

jieyouxu added the O-riscv Target: RISC-V architecture label Jun 15, 2025

workingjubilee reviewed Jun 16, 2025

View reviewed changes

	error[E0277]: the size for values of type `str` cannot be known at compilation time
	--> $DIR/debug.rs:57:46
	\|
	LL \| type TestAbiEqNonsense = (fn((str, str)), fn((str, str)));
	\| ^^^^^^^^^^ doesn't have a size known at compile-time
	\|
	= help: the trait `Sized` is not implemented for `str`
	= note: only the last element of a tuple may have a dynamically sized type

Attempted to fix #141972 Parameter ABI inconsistency error in Rust for RISC-V #141979

Are you sure you want to change the base?

Attempted to fix #141972 Parameter ABI inconsistency error in Rust for RISC-V #141979

Conversation

YingkaiLi-VM commented Jun 3, 2025

Uh oh!

rustbot commented Jun 3, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

workingjubilee commented Jun 3, 2025

Uh oh!

beetrees commented Jun 3, 2025

Uh oh!

workingjubilee commented Jun 3, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Jun 9, 2025

Uh oh!

This comment has been minimized.

YingkaiLi-VM commented Jun 11, 2025

Uh oh!

jieyouxu commented Jun 15, 2025

Uh oh!

workingjubilee Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YingkaiLi-VM Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

YingkaiLi-VM Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

workingjubilee Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

workingjubilee Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YingkaiLi-VM Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

workingjubilee Jun 16, 2025 •

edited

Loading

workingjubilee Jun 16, 2025 •

edited

Loading

workingjubilee Jun 16, 2025 •

edited

Loading